React Native 0.78 support #8120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4vidi
requested changes
Oct 15, 2025
| expect(tree.toJSON().children).toEqual(['Bob']); | ||
|
|
||
| // Re-render to see the updated state | ||
| rerender( |
There was a problem hiding this comment.
revisit whether this is indeed necessary
| expect(tree.toJSON().children).toEqual(['Bob']); | ||
|
|
||
| // Re-render to get updated content | ||
| rerender(<MyConnectedComponent renderCountIncrement={renderCountIncrement} />); |
There was a problem hiding this comment.
revisit whether actually necessary
| expect((tree.getInstance() as any)._reactInternalInstance.child.child.Fibernode.key).toEqual( | ||
| 'component1' | ||
| ); | ||
| // Note: This test is disabled (xit) and uses deprecated React internals |
There was a problem hiding this comment.
Is it possible to replace this with an equivalent expectation?
Comment on lines
+175
to
+182
| const mockComponent = { | ||
| props: { componentId: 'doNotUseThisId' }, | ||
| componentDidMount: jest.fn(), | ||
| componentWillUnmount: jest.fn(), | ||
| componentDidAppear: didAppearFn, | ||
| componentWillAppear: jest.fn(), | ||
| componentDidDisappear: jest.fn(), | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const mockComponent = { | |
| props: { componentId: 'doNotUseThisId' }, | |
| componentDidMount: jest.fn(), | |
| componentWillUnmount: jest.fn(), | |
| componentDidAppear: didAppearFn, | |
| componentWillAppear: jest.fn(), | |
| componentDidDisappear: jest.fn(), | |
| }; | |
| const mockComponent = aComponent('doNotUseThisId'); |
| return 'Hello'; | ||
| } | ||
| } | ||
| // SimpleScreen is no longer used in tests - replaced with mock components |
There was a problem hiding this comment.
Suggested change
| // SimpleScreen is no longer used in tests - replaced with mock components |
Comment on lines
+154
to
+161
| const mockComponent = { | ||
| props: { componentId: 'test' }, | ||
| componentDidMount: jest.fn(), | ||
| componentWillUnmount: jest.fn(), | ||
| componentDidAppear: didAppearFn, | ||
| componentWillAppear: jest.fn(), | ||
| componentDidDisappear: jest.fn(), | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const mockComponent = { | |
| props: { componentId: 'test' }, | |
| componentDidMount: jest.fn(), | |
| componentWillUnmount: jest.fn(), | |
| componentDidAppear: didAppearFn, | |
| componentWillAppear: jest.fn(), | |
| componentDidDisappear: jest.fn(), | |
| }; | |
| const mockComponent = aComponent('test'); |
Comment on lines
+143
to
+147
| const mockComponent2 = { | ||
| props: { componentId: 123 }, | ||
| componentDidMount: jest.fn(), | ||
| componentWillUnmount: jest.fn(), | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const mockComponent2 = { | |
| props: { componentId: 123 }, | |
| componentDidMount: jest.fn(), | |
| componentWillUnmount: jest.fn(), | |
| }; | |
| const mockComponent = aComponent(123); |
| const tree2 = renderer.create(<SimpleScreen componentId={123} />); | ||
| expect(() => uut.bindComponent(tree2.getInstance() as any)).toThrow(''); | ||
| // Create a mock component instance for testing | ||
| const mockComponent = { |
There was a problem hiding this comment.
Actually, why not keep SimpleScreen instead of resorting to mocks here?
* Implemented dynamic pipelines * Implemented dynamic pipelines for rn 77 and 78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.